Skip to content

fix: labels dropdown key field KER-422#1119

Merged
mikkojamG merged 1 commit intomainfrom
fix/KER-422-labels-key-field
Feb 21, 2025
Merged

fix: labels dropdown key field KER-422#1119
mikkojamG merged 1 commit intomainfrom
fix/KER-422-labels-key-field

Conversation

@mikkojamG
Copy link
Contributor

Combobox uses label as default key, which can cause problems with duplicate items.

@mikkojamG mikkojamG requested a review from arpargo February 21, 2025 05:54
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1119-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1119-ui.dev.hel.ninja 😆🎉🎉🎉

Copy link
Contributor

@arpargo arpargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikkojamG mikkojamG merged commit f86ec92 into main Feb 21, 2025
22 of 23 checks passed
@mikkojamG mikkojamG deleted the fix/KER-422-labels-key-field branch February 21, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants